Skip to content

Raise ValueError in _get_ordered_vertices() with "mixed" order #595

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Raise ValueError in _get_ordered_vertices() with "mixed" order #595

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
15c709e
Raise a ValueError in `_get_ordered_vertices()` with `"mixed"` core d…
tomvothecoder Sep 18, 2025
1a5eb22
Replace ValueError with NotImplementedError
tomvothecoder Sep 24, 2025
bde699c
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] Sep 24, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions cf_xarray/helpers.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -338,6 +338,12 @@ def _get_ordered_vertices(
elif order == "descending":
endpoints = np.maximum(bounds[..., :, 0], bounds[..., :, 1])
last_endpoint = np.minimum(bounds[..., -1, 0], bounds[..., -1, 1])
elif order == "mixed":
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Even if this is a private function, I would avoid having code that can result in an UnboundLocalError.
I suggest either replacing it with a bare else, or adding something like:

else:
    raise NotImplementedError(f"{order = }")

Copy link
Contributor Author

@tomvothecoder tomvothecoder Sep 24, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The new code raises a ValueError with order=mixed, so it shouldn't result in UnboundLocalError. However, I updated this conditional to else as a fall-back for any order value (even if it should only be ascending, descending, or mixed).

raise ValueError(
"Cannot determine vertices for non-monotonic bounds with mixed core "
"dimension orders. Try normalizing the coordinates to a monotonic "
"convention and try again."
)

vertices = np.concatenate(
[endpoints, np.expand_dims(last_endpoint, axis=-1)], axis=-1
Expand Down
Loading