Refactor core.py: Extract specialized functions into focused modules #454
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Create flox/scan.py with groupby_scan and related functions - Create flox/factorize.py with factorize_ and related functions - Move scan-related types to types.py under TYPE_CHECKING - Update imports across codebase (core, tests, benchmarks) - Maintain backward compatibility through __init__.py exports This improves code organization by separating scan operations and factorization logic from the large core.py module while preserving all existing functionality. 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <[email protected]>
- Move dask_groupby_agg, dask_groupby_scan, _grouped_combine, and _unify_chunks to flox/dask.py - Update imports in core.py and scan.py to use new dask module locations - Keep reindex_intermediates in core.py as requested - Maintain backward compatibility and library functionality 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <[email protected]>
- Relocates _postprocess_numbagg function from core.py to aggregate_numbagg.py - Updates import in core.py to use the new location - Groups numbagg-specific functionality together for better organization 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
scan.pyfactorize.pyreindex.pydask.pycubed.pyutils.pyaggregate_numbagg.pyImproves code organization while maintaining backward compatibility.
🤖 Generated with Claude Code