-
Notifications
You must be signed in to change notification settings - Fork 21
More stable algorithm for variance, standard deviation #456
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
jemmajeffree
wants to merge
51
commits into
xarray-contrib:main
Choose a base branch
from
jemmajeffree:var_algorithm
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 1 commit
Commits
Show all changes
51 commits
Select commit
Hold shift + click to select a range
0f29529
update to nanvar to use more stable algorithm if engine is flox
jemmajeffree 1fbf5f8
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] 322f511
[revert] only nanvar test
dcherian adab8e6
Some mods
dcherian 93cd9b3
Update flox/aggregations.py to neater tuple unpacking
jemmajeffree 2be4f74
Change np.all to all in flox/aggregate_flox.py
jemmajeffree edb655d
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] dd2e4b6
delete some resolved comments
jemmajeffree 936ed1d
Remove answered questions in comments
jemmajeffree 1968870
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] d036ebc
Merge branch 'main' into var_algorithm
jemmajeffree 12bcb0f
Remove more unnecessary comments
jemmajeffree 6f5bece
Merge branch 'var_algorithm' of github.com:jemmajeffree/flox into var…
jemmajeffree b1f7b5d
Remove _version.py
jemmajeffree cd9a8b8
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] 27448e4
Add preliminary test for std/var precision
jemmajeffree 10214cc
Merge branch 'var_algorithm' of github.com:jemmajeffree/flox into var…
jemmajeffree a81b1a3
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] 004fddc
Correct comment
jemmajeffree 4491ce9
fix merge conflicts
jemmajeffree c3a6d88
Update flox/aggregate_flox.py
jemmajeffree 4dcd7c2
Replace some list comprehension with tuple
jemmajeffree c101a2b
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] 98e1b4e
Fixes
dcherian d0d09df
minor edit for neater test reports.
dcherian 1139a9c
Fix another list/tuple comprehension
jemmajeffree 569629c
implement np.full
jemmajeffree 50ad095
Implement np.full and empty chunks in var_chunk
jemmajeffree f88e231
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] 77526fd
update comment
jemmajeffree 0f5d587
Fix merge conflict
jemmajeffree 31f30c9
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] 3b3369f
edits
dcherian 24fb532
support var, std
dcherian 177b8de
enable property tests
dcherian 7deb84a
cleanup
dcherian 120fbf3
xfail some
dcherian 4541c46
revert some
dcherian aa4b9b3
fix types
dcherian d5c59e3
adjust tolerance
dcherian b721433
disable for cubed
dcherian 4f26ed8
handle nans in check
dcherian d77c132
Promote var/std to float64 from the beginning (dodgy)
jemmajeffree 3cbe54c
Revert "Promote var/std to float64 from the beginning (dodgy)"
jemmajeffree d7d772c
Handle combine along multiple dimensions
jemmajeffree 9a51095
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] 1373318
Comments
jemmajeffree 4f15495
Technicalities regarding multiple dimensions in var combine
jemmajeffree 591997c
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] bbc0be2
more explicit NaNs in empty groups
jemmajeffree 63d7e96
Better "more explicit NaNs in empty groups"
dcherian File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.