Skip to content

avoid raising if x.y.0 does not exist #25

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Aug 29, 2025
Merged

avoid raising if x.y.0 does not exist #25

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
7f79719
use the first compatible version
keewis Aug 29, 2025
26c4339
temporarily add `netcdf4=1.7`
keewis Aug 29, 2025
56e26d4
remove `netcdf4` again
keewis Aug 29, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 9 additions & 1 deletion minimum_versions.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -230,7 +230,15 @@ def is_suitable_release(release):
def lookup_spec_release(spec, releases):
version = spec.version.extend_to_length(3)

return releases[spec.name][version]
compatible_versions = [
release
for v, release in releases[spec.name].items()
if v.compatible_with(version)
]
if not compatible_versions:
return Release(version="", build_number=0, timestamp=datetime.date(1970, 1, 1))

return compatible_versions[0]


def compare_versions(environments, policy_versions, ignored_violations):
Expand Down
Loading