fix: handle exception from autodoc for classes with __slots__#124
Open
Object905 wants to merge 2 commits intoxarray-contrib:mainfrom
Open
fix: handle exception from autodoc for classes with __slots__#124Object905 wants to merge 2 commits intoxarray-contrib:mainfrom
Object905 wants to merge 2 commits intoxarray-contrib:mainfrom
Conversation
for more information, see https://pre-commit.ci
Member
|
apologies for being really slow in responding. I've been trying to understand in which situation this may come up and tried to reproduce this but can't; neither adding Is this something you still need / would be willing to work on? If so, it would be great if we could create some examples for use in tests (which this package doesn't have right now, it is only checking that |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi. When
__slots__are added to class returned fromsphinx_accessorI've got an exception from autodoc.autodoc is trying to handle
parentinMethodDocumenteras class object, but i'ts actually may be an instance when this library is used, but it expectsparentto be class object, which always have__dict__, while instance with__slots__does not have__dict__Faced this issue in pola-rs/polars#13236
Exception