Add precommit

.github/workflows/pre-commit.yml

@@ -0,0 +1,26 @@
+name: Pre-commit
+
+on:
+  push:
+    branches:
+      - main
+  pull_request:
+    branches:
+      - main
+
+jobs:
+  pre-commit:
+    name: Pre-commit
+    runs-on: ubuntu-latest
+    steps:
+      - uses: actions/checkout@v4
+      - uses: actions/setup-python@v5
+        with:
+          python-version: "3.13"
+      - name: Install dependencies
+        run: |
+          python -m pip install --upgrade pip
+          pip install pre-commit
+          pip install -e ".[dev]"
+      - name: Run pre-commit
+        run: pre-commit run --all-files

.pre-commit-config.yaml

@@ -0,0 +1,26 @@
+# See https://pre-commit.com for more information
+# See https://pre-commit.com/hooks.html for more hooks
+repos:
+-   repo: https://github.com/pre-commit/pre-commit-hooks
+    rev: v5.0.0
+    hooks:
+    -   id: trailing-whitespace
+    -   id: end-of-file-fixer
+    -   id: check-added-large-files
+- repo: https://github.com/astral-sh/ruff-pre-commit
+  rev: v0.12.5
+  hooks:
+    - id: ruff-check
+      args: [--fix]        # optional, to autofix lint errors
+    - id: ruff-format
+- repo: https://github.com/RobertCraigie/pyright-python
+  rev: v1.1.403
+  hooks:
+    - id: pyright
+      name: "python · Check types"
+- repo: https://github.com/abravalheri/validate-pyproject
+  rev: v0.24.1
+  hooks:
+    - id: validate-pyproject
+      name: "python · Validate pyproject.toml"
+      additional_dependencies: ["validate-pyproject-schema-store[all]"]

README.md

@@ -1,7 +1,7 @@
 # Important Note
-This repository was a fork from [here](https://github.com/astropenguin/xarray-dataclasses). We are grateful for the 
-work of the developer on this repo. That being said, sadly the state on main has been the case that the code was 
-deleted and there has been no development for a while. Therefore, we intially decided to fork the repository and 
+This repository was a fork from [here](https://github.com/astropenguin/xarray-dataclasses). We are grateful for the
+work of the developer on this repo. That being said, sadly the state on main has been the case that the code was
+deleted and there has been no development for a while. Therefore, we intially decided to fork the repository and
 continue development here, where the community is better able to contribute to and maintain the project. We now changed
 it into a standalone repository.
 
@@ -392,7 +392,7 @@ pixi run pyright
 ```
 
 ### Creating documentation
-We also have a [documentation workflow] (Add link). However, if you want to locally create the documentation 
+We also have a [documentation workflow] (Add link). However, if you want to locally create the documentation
 run the following:
 
 ```shell

pyproject.toml

@@ -48,6 +48,7 @@ dev = [
     "pytest>=8.2",
     "sphinx>=7.1",
     "twine>=4.0.0",
+    "pre-commit>=4.2.0,<5"
 ]
 
 [tool.hatch.build]
@@ -72,10 +73,7 @@ dev = { features = ["dev"], solve-group = "default" }
 
 [tool.pixi.feature.dev.tasks]
 tests = "pytest"
-flake8 = "flake8 docs tests src/xarray_dataclasses"
-black = "black docs tests src/xarray_dataclasses"
 doc_build = { cmd = "sphinx-apidoc -efT -o docs/_apidoc src/xarray_dataclasses && sphinx-build -a docs docs/_build" }
-pyright = "pyright docs tests src/xarray_dataclasses"
 
 [tool.pyright]
 reportImportCycles = "warning"

src/xarray_dataclasses/__init__.py

@@ -27,8 +27,15 @@
 from . import dataoptions
 from . import typing
 from .__about__ import __version__
-from .dataarray import *
-from .dataset import *
-from .datamodel import *
-from .dataoptions import *
-from .typing import *
+from .dataarray import AsDataArray, asdataarray
+from .dataset import AsDataset, asdataset
+from .datamodel import DataModel
+from .dataoptions import DataOptions
+from .typing import (
+    Attr,
+    Coord,
+    Coordof,
+    Data,
+    Dataof,
+    Name,
+)

src/xarray_dataclasses/datamodel.py

@@ -187,12 +187,12 @@ def from_dataclass(cls, dataclass: AnyDataClass[PInit]) -> "DataModel":
         model = cls()
         eval_dataclass(dataclass)
 
-        for field in dataclass.__dataclass_fields__.values():
-            value = getattr(dataclass, field.name, MISSING)
-            entry = get_entry(field, value)
+        for field_value in dataclass.__dataclass_fields__.values():
+            value = getattr(dataclass, field_value.name, MISSING)
+            entry = get_entry(field_value, value)
 
             if entry is not None:
-                model.entries[field.name] = entry
+                model.entries[field_value.name] = entry
 
         return model
 
@@ -203,10 +203,10 @@ def eval_dataclass(dataclass: AnyDataClass[PInit]) -> None:
     if not is_dataclass(dataclass):
         raise TypeError("Not a dataclass or its object.")
 
-    fields = dataclass.__dataclass_fields__.values()
+    field_values = dataclass.__dataclass_fields__.values()
 
     # do nothing if field types are already evaluated
-    if not any(isinstance(field.type, str) for field in fields):
+    if not any(isinstance(field_value.type, str) for field_value in field_values):
         return
 
     # otherwise, replace field types with evaluated types
@@ -215,8 +215,8 @@ def eval_dataclass(dataclass: AnyDataClass[PInit]) -> None:
 
     types = get_type_hints(dataclass, include_extras=True)
 
-    for field in fields:
-        field.type = types[field.name]
+    for field_value in field_values:
+        field_value.type = types[field_value.name]
 
 
 def get_entry(field: AnyField, value: Any) -> Optional[AnyEntry]:

tests/test_datamodel.py

@@ -54,7 +54,7 @@ def test_xaxis_attr() -> None:
     assert units.tag == "attr"
     assert units.type is str
     assert units.value == "pixel"
-    assert units.cast == False
+    assert units.cast is False
 
 
 def test_xaxis_data() -> None:
@@ -64,7 +64,7 @@ def test_xaxis_data() -> None:
     assert data.dims == ("x",)
     assert data.dtype == "int"
     assert data.base is None
-    assert data.cast == True
+    assert data.cast is True
 
 
 def test_yaxis_attr() -> None:
@@ -73,7 +73,7 @@ def test_yaxis_attr() -> None:
     assert units.tag == "attr"
     assert units.type is str
     assert units.value == "pixel"
-    assert units.cast == False
+    assert units.cast is False
 
 
 def test_yaxis_data() -> None:
@@ -83,7 +83,7 @@ def test_yaxis_data() -> None:
     assert data.dims == ("y",)
     assert data.dtype == "int"
     assert data.base is None
-    assert data.cast == True
+    assert data.cast is True
 
 
 def test_image_coord() -> None:
@@ -93,23 +93,23 @@ def test_image_coord() -> None:
     assert mask.dims == ("x", "y")
     assert mask.dtype == "bool"
     assert mask.base is None
-    assert mask.cast == True
+    assert mask.cast is True
 
     x = image_model.coords[1]
     assert x.name == "x"
     assert x.tag == "coord"
     assert x.dims == ("x",)
     assert x.dtype == "int"
     assert x.base is XAxis
-    assert x.cast == True
+    assert x.cast is True
 
     y = image_model.coords[2]
     assert y.name == "y"
     assert y.tag == "coord"
     assert y.dims == ("y",)
     assert y.dtype == "int"
     assert y.base is YAxis
-    assert y.cast == True
+    assert y.cast is True
 
 
 def test_image_data() -> None:
@@ -119,7 +119,7 @@ def test_image_data() -> None:
     assert data.dims == ("x", "y")
     assert data.dtype == "float"
     assert data.base is None
-    assert data.cast == True
+    assert data.cast is True
 
 
 def test_color_data() -> None:
@@ -129,20 +129,20 @@ def test_color_data() -> None:
     assert red.dims == ("x", "y")
     assert red.dtype == "float"
     assert red.base is Image
-    assert red.cast == True
+    assert red.cast is True
 
     green = color_model.data_vars[1]
     assert green.name == "green"
     assert green.tag == "data"
     assert green.dims == ("x", "y")
     assert green.dtype == "float"
     assert green.base is Image
-    assert green.cast == True
+    assert green.cast is True
 
     blue = color_model.data_vars[2]
     assert blue.name == "blue"
     assert blue.tag == "data"
     assert blue.dims == ("x", "y")
     assert blue.dtype == "float"
     assert blue.base is Image
-    assert blue.cast == True
+    assert blue.cast is True