-
Notifications
You must be signed in to change notification settings - Fork 20
support querying by geometries #169
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
keewis
wants to merge
7
commits into
xarray-contrib:main
Choose a base branch
from
keewis:query
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Changes from 6 commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
eff042a
basic infrastructure for query
keewis fa2ef8f
implement `rasterize_geometry` for healpix
keewis 89a33a9
implement `rasterize_geometry` for h3
keewis 6a99620
Merge branch 'main' into query
keewis fd1fec8
Merge branch 'main' into query
keewis 9adeda5
bump lockfile again
keewis 2e673a2
Merge branch 'main' into query
keewis File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The name
rasterize_geometry
is misleading here. This function basically converts an arbitrary geometry to cell ids so I would suggest a name likegeometry2cells_ids
that is consistent with the other methods ofDGGSInfo
.Adding type hints would help too. Is this method intended to support multiple geometries in the future?
The name
mode
is a bit too generic. Shall we usecontainment_mode
like h3ronpy?Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Unless you assume "raster" to equal 2D image (I understand "rasterize" as "to discretize onto a grid") I don't see how the name would be misleading. However, you have a point with the consistency argument.
We currently don't have type hints on any of the methods, so we'd have to figure out common type hints, first. Maybe in a new PR?
Potentially, although I'd say querying by a single geometry covers at least 90% of the use-cases for
query
(and I'm currently not planning to vectorize it).Indeed, but
containment_mode
is also quite the mouthful. I'd argue that in the context of rasterization / conversion to cell ids the wordmode
is unambiguous, but if that doesn't convince you we can just remove the wordmode
and usecontainment="center"
orcontainment="overlap"
or something similar, likecontained=...
.