Merged
Conversation
|
Caution Review failedThe pull request is closed. WalkthroughThis update advances the project by upgrading the linting workflow, expanding ignore patterns, and refining the Windows release configuration. New dialog commands (start, replay, and a parent dialog command) have been added and registered to the CLI. Comprehensive documentation for these commands is introduced, along with new types and utility functions for resource management. Several pkg modules have been updated to use a custom SafeClose function for improved error handling during resource cleanup. Changes
Sequence Diagram(s)sequenceDiagram
participant U as User
participant CLI as CLI Application
participant DM as Voiceflow Dialog Manager
participant FS as File System
U->>CLI: Execute "dialog start" command with flags
CLI->>CLI: Setup environment & signal handlers
CLI->>DM: Initiate dialog session
DM-->>CLI: Return initial response
CLI->>FS: Record conversation (if enabled)
U->>CLI: Provide input
CLI->>DM: Send user input
DM-->>CLI: Return dialog response
CLI->>FS: Append interaction to record
sequenceDiagram
participant U as User
participant CLI as CLI Application
participant FS as File System
participant DM as Voiceflow Dialog Manager
U->>CLI: Execute "dialog replay" command with record file
CLI->>FS: Load recorded conversation
loop For each interaction
CLI->>DM: Replay interaction
DM-->>CLI: Return replay response
end
CLI->>U: Display conversation replay
Poem
📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (29)
✨ Finishing Touches
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
Bumps [golangci/golangci-lint-action](https://github.com/golangci/golangci-lint-action) from 6 to 7. - [Release notes](https://github.com/golangci/golangci-lint-action/releases) - [Commits](golangci/golangci-lint-action@v6...v7) --- updated-dependencies: - dependency-name: golangci/golangci-lint-action dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
There was a problem hiding this comment.
Pull Request Overview
This PR adds dialog commands ("start" and "replay") to the Voiceflow CLI, enabling interactive conversation sessions, conversation recording, and replay capabilities. Key changes include refactoring transcript processing for better structure, integrating a SafeClose helper for resource cleanup, and adding new command implementations and documentation for dialog functionality.
Reviewed Changes
Copilot reviewed 29 out of 29 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| pkg/transcript/to-test.go | Refactored conditional handling in transcript conversion with a switch statement. |
| pkg/openai/similarity.go | Updated resource cleanup to use SafeClose for improved error handling. |
| pkg/dialog/replay.go | Introduced the new dialog replay functionality. |
| internal/utils/files.go & closer.go | Updated file handling to leverage SafeClose. |
| internal/types/voiceflow/dialog/dialog.go | Added types for handling recorded dialog conversations. |
| docs/* | Added documentation for the new dialog commands. |
| cmd/dialog/* | Added new CLI commands for starting and replaying dialogs. |
| .goreleaser.yml & .github/workflows/lint.yaml | Updated configuration files for releases and linting. |
Comments suppressed due to low confidence (2)
cmd/dialog/start.go:40
- [nitpick] The shorthand flag 'r' for user-id might be confusing; consider using a more intuitive option like 'u'.
startCmd.Flags().StringP("user-id", "r", "", "User ID for the dialog (optional)")
cmd/dialog/replay.go:39
- [nitpick] The shorthand flag 'r' for user-id might be better as 'u' for clarity and consistency with common conventions.
replayCmd.Flags().StringP("user-id", "r", "", "User ID for the dialog (optional)")
| } | ||
| for index, turn := range transcriptJSON { | ||
| if turn.Type == "launch" { | ||
| switch turn.Type { |
There was a problem hiding this comment.
Consider adding a default case to the switch statement to handle unexpected turn types.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added dialog commands
Summary by CodeRabbit
New Features
Documentation
Chores