Added additional target framework of .Net Framework 4.5.#5
Open
rossknudsen wants to merge 1 commit intoxaviergonz:masterfrom
Open
Added additional target framework of .Net Framework 4.5.#5rossknudsen wants to merge 1 commit intoxaviergonz:masterfrom
rossknudsen wants to merge 1 commit intoxaviergonz:masterfrom
Conversation
Added configuration to allow VS2017 to build Nuget package from the .csproj definition.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi @xaviergonz,
Here is a simple PR with a couple of changes that I made. I wanted to use your project in a Unity3D application which currently requires the full .Net Framework (experimental support for 4.5). So I've added the target to the project definition.
I also changed the configuration so that the Nuget package should be correctly built from within Visual Studio 2017 (or presumably MSBuild on the command line). If you have access to this version of Visual Studio, you may consider removing the packaging script and nuspec file, as they are no longer required.
Let me know what you think.