Rework custom buttons #1440
Open
Rework custom buttons #1440
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wutschel
force-pushed
the
rework_custombuttons
branch
from
80699a5 to
2c623b3
Compare
Introduce a label which shows the information that no custom button has been defined yet. This label is faded in/out depending on the button list content. This allows to avoid calling reloadData and using a fake button with the same information.
Correctly use UIControlStateNormal and UIControlStateSelected for editTableButton.
These keys were either not used at all ("helpText", "xbmxSettings, "revealViewTop") or are not needed anymore as all buttons are editable ("isSettings") nowadays.
wutschel
force-pushed
the
rework_custombuttons
branch
from
2c623b3 to
cb0372e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This rework was triggered by the recent observations that
reloadDatais called too often. In the custom button view signaling "No custom button defined" was done by adding a dummy button and callingreloadDatato show it. This PR replaces this approach by introducing aUILabelwhich is faded in/out as needed. This allows to remove the dummy button logic and the related calls ofreloadData. While working on this, I also recognized thatUIButtoncontrol state were not correctly used and did rework this, as well as removing some superfluous keys.Summary for release notes
Improvement: Correctly use UIButton control states in custom button view
Improvement: Avoid calling reloadData by using UILabel to signal "No custom button defined"