Conversation
|
@xcarpentier Could you help merge these changes or assign someone to do so? Seems all checks have passed. Thx |
|
Please merge, thank you! |
|
If it's not merged soon I will create a @vricosti/react-native-country-picker-modal package as I already did for some unmaintained package (@vricosti/react-native-asset). |
|
I tried to generate on my fork and I have ts errors: so what about: {...props} already includes placeholder and autoFocus because it's built from CountryFilterProps. |
|
Hi Can this get merged please? @xcarpentier |
Merged here: https://github.com/vricosti/react-native-country-picker-modal |
JamieColclough
left a comment
There was a problem hiding this comment.
@xcarpentier This is a really simple change that will help a lot of people who are using libraries that depend on this. Please can you merge, it's only a few lines of changes?
Fixes issues with
defaultProps, which is incompatible with 0.78 / React 19 and throws an error.Fixes #536
Fixes #526
Fixes #535
Duplicates (sorry, I didn't see them)
Duplicate of #531
Duplicate of #529