Fix non-local networks being skipped in makedhcp

[lebonez]

If this logic check exists all non-local virtual networks are skipped if the site table has dhcpinterfaces defined or if the node is an enabled service node with dhcpinterfaces defined. Obviously this requires querynics to occur and to have at least one network mgtifname be set to '!remote!' I'd be interested if anyone knows the consequences if any of removing these lines? Our setup does not work since we use the site table to define interfaces on a per service/management node definition. Maybe someone also has a recommendation of best configuration for a combination of service nodes and remote (non-local) networks? Do we use the site table or service node table for dhcpinterfaces? Or do we just use the networks table by itself?

[lebonez]

Looking at this closer the only configuration that will work is to have servicenodes all defined with mgtifname set to something like "!remote!,eth0" and no dhcpinterfaces set in the site table or have no service nodes with dhcpinterfaces and have at least one network set with mgtifname = !remote!. This does not seem valid but the last one seems the most realistic.

[CLAassistant]

Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
_{You have signed the CLA already but the status is still pending? Let us recheck it.}