Merged
Conversation
Collaborator
BrandtH22
commented
Dec 29, 2024
BrandtH22
commented
- fixes token sorting for alphabet and balance
- adds loading and confirmation to offers
- sort by balance had 0 balance, 0 value tokens at the top, this moves them to the bottom. - sort by name had unknown cat at the top, this moves them to the bottom
note there is an issue with the summary on the confirmation screen but the json works
Rigidity
reviewed
Dec 30, 2024
Collaborator
|
Long term I plan to make loading offers faster, but it will probably still take long enough that a spinner is good to have. |
Collaborator
Author
I also figure it might be helpful in other future sections like when building reports for export 🤔 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.