Rewrite base of selectors to shadcn/command#724
Closed
dkackman wants to merge 4 commits intoxch-dev:mainfrom
Closed
Rewrite base of selectors to shadcn/command#724dkackman wants to merge 4 commits intoxch-dev:mainfrom
dkackman wants to merge 4 commits intoxch-dev:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
FIX #704
This uses the Command component to encapsulate the selector ui (paging, searching, listing, selecting)
note
In order to test the android and ios parts i had to base this on those changes (#718). If we decide we don't need or want those changes cherry pick commit be37b7b to get the selector changes only. It isn't dependent on anything in those branches other than the ability to run on mobile in my environemnt.