fix for other-config: scheduler v2#28
Open
andrey-podko wants to merge 1 commit intoxcp-ng:2.30.7-8.2from
Open
Conversation
- fixed call diskFromPartition() from block_setscheduler: it requires path without /dev/ - diskFromPartition() should remove trailing "p" for NVMe drives too - forced setup of CFQ scheduler skipped for NVMe drives, because it's unsupported Signed-off-by: Andrew Podko <podko.andrew@gmail.com>
Member
|
Hello, thank you for this contribution. But you should open a PR directly in the upstream repository: https://github.com/xapi-project/sm It's not a trivial change, so it might be good to get an opinion from the upstream maintainers, and also this change can be interesting for all XAPI users, not only XCP-ng. :) |
Member
|
I don't see a PR for this on https://github.com/xapi-project/sm/pulls @andrey-podko did you create it? |
Author
|
@stormi unfortunately no, I didn't have enough time to figure out this repository (( |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PS
My apologize for some disorder in previous version of this PR. Some unexpected troubles with gpg signature ((