a-posteriori review and fixes of Linstor tests #328
+28
−20
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This particular package will be removed by the `saved_yum_state` fixture. If removing this code breaks other tests, then it is likely the latter that need fixing. Signed-off-by: Yann Dirson <[email protected]>
Signed-off-by: Yann Dirson <[email protected]>
"assert" here will show the test as FAILED, where in fact the test was not run. This makes it a fixture, so at least the test is just marked ERROR when that happens. FIXME: python-linstor still sounds a strange package to test for
| @@ -43,17 +43,30 @@ def lvm_disks(host, sr_disks_for_all_hosts, provisioning_type): | |||
|
|
|||
| @pytest.fixture(scope="package") | |||
| def storage_pool_name(provisioning_type): | |||
| # FIXME: this needs an explanation | |||
There was a problem hiding this comment.
This is to dynamically handle the provisioning_type used for building GROUP_NAME. Please see comment for def provisioning_type for more.
| return GROUP_NAME if provisioning_type == "thick" else STORAGE_POOL_NAME | ||
|
|
||
| # FIXME why having this feature of session scope? Shouldn't it make | ||
| # it impossible to run both thin and thick tests in the same session? |
There was a problem hiding this comment.
Since all linstor tests were going to be repeated with just one change of SR type, pytest params technique was used.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First version is only driven by the
TestLinstorSRCreateDestroyclass of tests. I propose fixes for the problems I see with obvious solutions (and some changes that are merely improvements), and insert FIXME's in the places I see as potentially problematic.