host.reboot: fix detection of host up/down #332
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When rebooting a master host, and no VM is running, it can get down fast enough that the ssh connection is closed on us. In this case (which we already handled) trying to open a new ssh connection to query xapi is never going to succeed. Even when a xapi master answers a slave is not enabled it is a bit of a stretch to conclude the host is down already. Especially, the test for "host up" uses ping, and the host might still respond to a few pings before it actually shuts down. Instead, for robustness of the "host up" test, it is much more logical to use ping as well to decide the host is down.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When rebooting a master host, and no VM is running, it can get down fast enough that the ssh connection is closed on us. In this case (which we already handled) trying to open a new ssh connection to query xapi is never going to succeed. Even when a xapi master answers a slave is not enabled it is a bit of a stretch to conclude the host is down already.
Especially, the test for "host up" uses ping, and the host might still respond to a few pings before it actually shuts down. Instead, for robustness of the "host up" test, it is much more logical to use ping as well to decide the host is down.