-
Notifications
You must be signed in to change notification settings - Fork 6
Storage Tests for qcow2 vdi image format #339
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
rushikeshjadhav
wants to merge
19
commits into
xcp-ng:master
Choose a base branch
from
rushikeshjadhav:storage-qcow2
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add a vdi-type parameter to parametrize the vdi_type fixture, it default to vhd at the moment, will be used to run test on other vdi type, e.g. qcow2. The tests create a VDI, connect it to Dom0 then use the tapdev to write random data somewhere in it. It then compare the data of the VDI to the original data we have to see if it has changed. The test create snapshot/clone before deleting them and waiting for the coalesce to have happened by observing sm-config:vhd-parent before checking the integrity of the data. Signed-off-by: Damien Thenot <[email protected]>
Adapt waiting for coalesce to fail with a timeout if coalesce doesn't happen using wait_for. Signed-off-by: Damien Thenot <[email protected]>
Signed-off-by: Damien Thenot <[email protected]>
vdi.py: add getting the image_format if available sr.py: add choosing a image_format on vdi creation sr.py add get_type to get the type of the SR Signed-off-by: Damien Thenot <[email protected]>
Add a fixture `shared_sr` to get a shared SR Also modify local_sr_* function to log the SR type Signed-off-by: Damien Thenot <[email protected]>
Now use `SR.create_vdi` to create a VDI with the chosen image_format Signed-off-by: Damien Thenot <[email protected]>
Signed-off-by: Damien Thenot <[email protected]>
Add a list of vdis object to a VM Add get_dom0_vm in host.py Add function to connect/disconnect a VDI from a VM Signed-off-by: Damien Thenot <[email protected]>
Signed-off-by: Damien Thenot <[email protected]>
It will allow to re-use in other tests Signed-off-by: Damien Thenot <[email protected]>
Signed-off-by: Damien Thenot <[email protected]>
… vhd,qcow2) Signed-off-by: Rushikesh Jadhav <[email protected]>
… format Signed-off-by: Rushikesh Jadhav <[email protected]>
…te_script scp Using the same path for both source and destination may cause scp to fail, especially when the source path (e.g. a temp path on macOS) does not exist on the remote system. Thus, resorting to use `/tmp/` and random name from `sctipt.name` on destination. Signed-off-by: Rushikesh Jadhav <[email protected]>
… format Signed-off-by: Rushikesh Jadhav <[email protected]>
… format Signed-off-by: Rushikesh Jadhav <[email protected]>
… format Signed-off-by: Rushikesh Jadhav <[email protected]>
… image format Signed-off-by: Rushikesh Jadhav <[email protected]>
…cow2 vdi image format Signed-off-by: Rushikesh Jadhav <[email protected]>
0610307
to
c421cc4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Incorporating
image-format
fixture into following SR types for storage tests