-
Notifications
You must be signed in to change notification settings - Fork 6
Import configuration enhancements from python-project-template #342
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
This pull request sets up GitHub code scanning for this repository. Once the scans have completed and the checks have passed, the analysis results for this pull request branch will appear on this overview. Once you merge this pull request, the 'Security' tab will show more code scanning analysis results (for example, for the default branch). Depending on your configuration and choice of analysis tool, future pull requests will be annotated with code scanning analysis results. For more information about GitHub code scanning, check out the documentation. |
1 similar comment
This pull request sets up GitHub code scanning for this repository. Once the scans have completed and the checks have passed, the analysis results for this pull request branch will appear on this overview. Once you merge this pull request, the 'Security' tab will show more code scanning analysis results (for example, for the default branch). Depending on your configuration and choice of analysis tool, future pull requests will be annotated with code scanning analysis results. For more information about GitHub code scanning, check out the documentation. |
.github/workflows/jobs-check.yml
Outdated
- name: Install uv | ||
uses: astral-sh/setup-uv@v6 | ||
uses: astral-sh/setup-uv@bd01e18f51369d5a26f1651c3cb451d3417e3bba # v6.3.1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are all these different workflow files needed?
I'd rather a single file that reuses a single step that installs uv and its cache, and have different jobs that run. Having this many files means it will be very easy to miss updating some of the versions of the actions
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Those files were there before me, so I can't say why this way to organize the jobs was chosen.
I'm not much bothered by the update: I use ambr actions/checkout@v2 actions/checkout@v4
to update something and be sure to not miss anything. But I sure think that's quite a lot of duplication.
We could also define a custom action that checks out the repository and install uv.
Something like (not tested):
# .github/actions/setup/action.yml
name: setup
description: 'Checkout the repository and install uv'
runs:
using: 'composite'
steps:
- uses: actions/checkout@v4
with:
persist-credentials: false
- uses: astral-sh/setup-uv@bd01e18f51369d5a26f1651c3cb451d3417e3bba # v6.3.1
with:
version: "0.7.x"
and use it in the jobs:
jobs:
flake8:
runs-on: ubuntu-latest
steps:
- uses: ./.github/actions/setup/
- run: uv sync --frozen
- run: uv run flake8
Signed-off-by: Gaëtan Lehmann <[email protected]>
da294e4
to
eed82a6
Compare
Remove redudant job names Names are useful when they describe what is done in a more concise way than the code. Remove sarif support: it's too permissive in the github webui: it is made to be able to configure some warning or errors to ignore. Signed-off-by: Gaëtan Lehmann <[email protected]>
No description provided.