Merged
Conversation
Collaborator
Author
|
Note that this is still missing the predict part for now. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #199 +/- ##
=======================================
Coverage 70.58% 70.58%
=======================================
Files 61 61
Lines 8939 8939
Branches 933 933
=======================================
Hits 6310 6310
Misses 2629 2629 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
ceb9126 to
612e807
Compare
Collaborator
Author
|
I added the same code to |
Collaborator
Author
|
This could be cleaned up a bit (e.g. storing |
ba52eae to
ca15acd
Compare
rpreen
approved these changes
Jul 16, 2025
rpreen
pushed a commit
that referenced
this pull request
Jul 21, 2025
rpreen
added a commit
that referenced
this pull request
Jul 21, 2025
* [pre-commit.ci] pre-commit autoupdate updates: - [github.com/pre-commit/mirrors-clang-format: v20.1.7 → v20.1.8](pre-commit/mirrors-clang-format@v20.1.7...v20.1.8) - [github.com/astral-sh/ruff-pre-commit: v0.12.2 → v0.12.3](astral-sh/ruff-pre-commit@v0.12.2...v0.12.3) * Add checks for array contiguity (#199) Fixes #198. * Add `clean` parameter to `json_read` (#202) * add Ruff Python linting/formatting * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci --------- Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Co-authored-by: David Pätzel <david.paetzel@posteo.de> Co-authored-by: Richard Preen <rpreen@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #198 for now by throwing an error.
For me, this works: