feat: use proper tempfiles in {de,}serialize #204
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #204 +/- ##
=======================================
Coverage 70.59% 70.59%
=======================================
Files 61 61
Lines 8940 8940
Branches 934 934
=======================================
Hits 6311 6311
Misses 2629 2629 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
Looks like Windows doesn't like it. |
|
Yeah, right, I'm sorry. 🙁 I would have to check how to make this work on Windows. Probably via some |
|
Right now, I can't make the time, though. Maybe just keep this open until when I do find some time … |
Serialization was broken/errored due to always using the same fixed file name for the temporary pickle files. This is a problem in setups where multiple instances of XCSF run in parallel (e.g. on Slurm clusters).
dpaetzel
force-pushed
the
fix-serialization-tmp-fname
branch
from
bc84506 to
beb78b1
Compare
for more information, see https://pre-commit.ci
rpreen
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Serialization is broken due to always using the same fixed file name (relative to the current working directory) for the temporary pickle files. This is a problem in setups where multiple instances of XCSF run in parallel (e.g. on Slurm clusters).
This PR simply replaces the hardcoded file name with
mkstemp.