Skip to content

Fix json_read crashing when the new population is empty#205

Merged
rpreen merged 2 commits intoxcsf-dev:masterfrom
dpaetzel:fix-json-read-empty
Jul 25, 2025
Merged

Fix json_read crashing when the new population is empty#205
rpreen merged 2 commits intoxcsf-dev:masterfrom
dpaetzel:fix-json-read-empty

Conversation

@dpaetzel
Copy link
Copy Markdown
Collaborator

I.e. when the JSON file only contains { "classifiers" : [] }. This so far always resulted in a segfault which can't be desired.

@dpaetzel dpaetzel requested a review from rpreen July 25, 2025 14:26
@codecov
Copy link
Copy Markdown

codecov bot commented Jul 25, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 70.59%. Comparing base (bf87a28) to head (7f3f7e6).
⚠️ Report is 2 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #205   +/-   ##
=======================================
  Coverage   70.58%   70.59%           
=======================================
  Files          61       61           
  Lines        8939     8940    +1     
  Branches      933      934    +1     
=======================================
+ Hits         6310     6311    +1     
  Misses       2629     2629           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@dpaetzel
Copy link
Copy Markdown
Collaborator Author

The jobs fail probably because of the C tests, I'll check, sorry

@dpaetzel dpaetzel force-pushed the fix-json-read-empty branch from 00c8a27 to 240569d Compare July 25, 2025 15:45
Copy link
Copy Markdown
Member

@rpreen rpreen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this fix.

@rpreen rpreen merged commit faac8aa into xcsf-dev:master Jul 25, 2025
9 of 10 checks passed
@dpaetzel dpaetzel deleted the fix-json-read-empty branch July 25, 2025 15:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants