Fix json_read crashing when the new population is empty#205
Merged
rpreen merged 2 commits intoxcsf-dev:masterfrom Jul 25, 2025
Merged
Fix json_read crashing when the new population is empty#205rpreen merged 2 commits intoxcsf-dev:masterfrom
json_read crashing when the new population is empty#205rpreen merged 2 commits intoxcsf-dev:masterfrom
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #205 +/- ##
=======================================
Coverage 70.58% 70.59%
=======================================
Files 61 61
Lines 8939 8940 +1
Branches 933 934 +1
=======================================
+ Hits 6310 6311 +1
Misses 2629 2629 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Collaborator
Author
|
The jobs fail probably because of the C tests, I'll check, sorry |
rpreen
requested changes
Jul 25, 2025
00c8a27 to
240569d
Compare
for more information, see https://pre-commit.ci
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I.e. when the JSON file only contains
{ "classifiers" : [] }. This so far always resulted in a segfault which can't be desired.