clamp ubr hyperrectangle conditions within min/max during covering#215
Merged
clamp ubr hyperrectangle conditions within min/max during covering#215
Conversation
rpreen
changed the title
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #215 +/- ##
=======================================
Coverage 70.59% 70.60%
=======================================
Files 61 61
Lines 8941 8943 +2
Branches 934 934
=======================================
+ Hits 6312 6314 +2
Misses 2629 2629 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently it is possible that unordered-bound hyperrectangle conditions can be set slightly outside of the specified min/max during covering. For example, even if
minis set to0, a covered interval could be negative. This is highly unlikely to make any real performance difference (especially since during mutation, the bounds are clamped) - but this change guarantees that the intervals are always within the specified range.