-
Notifications
You must be signed in to change notification settings - Fork 20
WebAPI: Add resolutions and spatialUnits to mldataset #1177
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All fine, but please write a CHANGELOG entry.
Although the code is covered by at least one test, none of them really asserts the correctness of the new settings. Consider writing a new unit test or enhancing one.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is actually approved, but CI still fails. Please fix.
|
The tests related this PR have been adjusted. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1177 +/- ##
==========================================
+ Coverage 89.51% 89.52% +0.01%
==========================================
Files 280 280
Lines 21659 21661 +2
==========================================
+ Hits 19387 19391 +4
+ Misses 2272 2270 -2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This PR:
Checklist:
docs/source/*CHANGES.md