Skip to content

Commit 2d42cf7

Browse files
authored
fix: handle root extended property on eval response (#754)
1 parent 6b25353 commit 2d42cf7

File tree

2 files changed

+5
-1
lines changed

2 files changed

+5
-1
lines changed

CHANGELOG.md

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -4,6 +4,10 @@ All notable changes to this project will be documented in this file.
44

55
The format is based on [Keep a Changelog](http://keepachangelog.com/) and this project adheres to [Semantic Versioning](http://semver.org/).
66

7+
## [1.24.2]
8+
9+
- Additional fix for extended root property in eval #751
10+
711
## [1.24.1]
812

913
- Fix for extended root property #751

src/xdebugConnection.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -670,7 +670,7 @@ export class EvalResultProperty extends BaseProperty {
670670
constructor(propertyNode: Element) {
671671
super(propertyNode)
672672
if (this.hasChildren) {
673-
this.children = Array.from(propertyNode.childNodes).map(
673+
this.children = Array.from(propertyNode.getElementsByTagName('property')).map(
674674
(propertyNode: Element) => new EvalResultProperty(propertyNode)
675675
)
676676
}

0 commit comments

Comments
 (0)