Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
54 commits
Select commit Hold shift + click to select a range
029bf2f
Don't fail on broken links
AB-xdev Oct 21, 2024
d8499f5
Merge branch 'master' into update-from-template-merged
xdev-gh-bot Oct 22, 2024
9ad20ee
Update dependency org.apache.maven.plugins:maven-project-info-reports…
xdev-renovate Oct 22, 2024
04e7b76
Merge pull request #107 from xdev-software/renovate/org.apache.maven.…
AB-xdev Oct 23, 2024
009f795
Initial commit
AB-xdev Oct 24, 2024
efcd43e
Init
AB-xdev Oct 24, 2024
eeb917d
Merge remote-tracking branch 'origin/update-from-template'
AB-xdev Oct 24, 2024
b8de24f
Merge branch 'master' into update-from-template-merged
xdev-gh-bot Oct 24, 2024
473ce31
Update dependency org.apache.maven.plugins:maven-checkstyle-plugin to…
xdev-renovate Oct 26, 2024
f2c6db4
Update dependency org.apache.maven.plugins:maven-jxr-plugin to v3.6.0
xdev-renovate Oct 26, 2024
216f465
Update net.sourceforge.pmd to v7.7.0
xdev-renovate Oct 26, 2024
f798625
Update dependency com.puppycrawl.tools:checkstyle to v10.19.0
xdev-renovate Oct 27, 2024
27773a3
Merge branch 'develop' into update-from-template-merged
xdev-gh-bot Oct 28, 2024
5f47092
Merge pull request #111 from xdev-software/renovate/net.sourceforge.pmd
AB-xdev Oct 28, 2024
07efa5e
Merge pull request #112 from xdev-software/renovate/com.puppycrawl.to…
AB-xdev Oct 28, 2024
5bcfa6a
Merge pull request #110 from xdev-software/renovate/org.apache.maven.…
AB-xdev Oct 28, 2024
186b89e
Merge pull request #109 from xdev-software/renovate/org.apache.maven.…
AB-xdev Oct 28, 2024
d13b2de
Changes for PMD 7.7
AB-xdev Oct 28, 2024
526dc31
Merge branch 'master' into update-from-template-merged
xdev-gh-bot Oct 28, 2024
a2d6ebc
Update dependency org.apache.maven.plugins:maven-pmd-plugin to v3.26.0
xdev-renovate Oct 29, 2024
9e9f2a9
Tighten timeouts
AB-xdev Oct 30, 2024
02fc7af
Tighten timeouts
AB-xdev Oct 30, 2024
f01dac4
Merge branch 'master' into update-from-template-merged
xdev-gh-bot Oct 30, 2024
9013244
Merge pull request #114 from xdev-software/renovate/org.apache.maven.…
AB-xdev Oct 30, 2024
89a6b05
Update check-build.yml
AB-xdev Oct 30, 2024
1b39a9f
Merge branch 'master' of https://github.com/xdev-software/standard-ma…
AB-xdev Oct 30, 2024
71f1b1d
Update dependency com.puppycrawl.tools:checkstyle to v10.20.0
xdev-renovate Nov 1, 2024
d7b7b8a
Update dependency org.apache.maven.plugins:maven-javadoc-plugin to v3…
xdev-renovate Nov 3, 2024
402eec8
Merge branch 'develop' into update-from-template-merged
xdev-gh-bot Nov 4, 2024
1de2699
Merge pull request #116 from xdev-software/renovate/com.puppycrawl.to…
AB-xdev Nov 4, 2024
06e8428
Merge pull request #117 from xdev-software/renovate/org.apache.maven.…
AB-xdev Nov 4, 2024
d7926e6
Update dependency com.puppycrawl.tools:checkstyle to v10.20.1
xdev-renovate Nov 8, 2024
327f4f3
Merge branch 'develop' into update-from-template-merged
xdev-gh-bot Nov 11, 2024
8d16f5b
Update CheckStyle version
AB-xdev Nov 11, 2024
19236b6
Merge pull request #118 from xdev-software/renovate/com.puppycrawl.to…
AB-xdev Nov 11, 2024
946e9b2
Merge branch 'master' into update-from-template-merged
xdev-gh-bot Nov 12, 2024
f9ecc81
Merge branch 'develop' into update-from-template-merged
xdev-gh-bot Nov 18, 2024
b4fd24a
Update dependency com.fasterxml.jackson.core:jackson-databind to v2.18.1
xdev-renovate Nov 18, 2024
7522585
Update dependency org.apache.maven.plugins:maven-surefire-plugin to v…
xdev-renovate Nov 18, 2024
fe63516
Update dependency org.junit.jupiter:junit-jupiter to v5.11.3
xdev-renovate Nov 18, 2024
bf95352
Update testcontainers-version to v1.20.3
xdev-renovate Nov 18, 2024
130295d
Update dependency org.seleniumhq.selenium:selenium-chrome-driver to v…
xdev-renovate Nov 18, 2024
f0f0892
Update dependency software.xdev:testcontainers-selenium to v1.1.0
xdev-renovate Nov 18, 2024
2a4179c
PointStyle can also contain non-string constants
AB-xdev Nov 18, 2024
266b81c
Update version
AB-xdev Nov 18, 2024
63d06ff
Merge remote-tracking branch 'origin/master' into develop
AB-xdev Nov 18, 2024
72f6520
Merge pull request #257 from xdev-software/renovate/testcontainers-ve…
AB-xdev Nov 18, 2024
e67ffcf
Merge pull request #277 from xdev-software/renovate/org.apache.maven.…
AB-xdev Nov 18, 2024
64e2a82
Merge pull request #275 from xdev-software/renovate/org.seleniumhq.se…
AB-xdev Nov 18, 2024
f9460c9
Merge pull request #273 from xdev-software/renovate/com.fasterxml.jac…
AB-xdev Nov 18, 2024
20cebb9
Merge pull request #269 from xdev-software/renovate/software.xdev-tes…
AB-xdev Nov 18, 2024
5eb38a3
Merge pull request #265 from xdev-software/renovate/org.junit.jupiter…
AB-xdev Nov 18, 2024
3c796fb
Update ChartJS to latest version
AB-xdev Nov 18, 2024
9c9f41f
Use ``CoreInteractionOptions`` for ``Options#interaction`` and ``Opt…
AB-xdev Nov 18, 2024
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions .config/pmd/ruleset.xml
Original file line number Diff line number Diff line change
Expand Up @@ -151,5 +151,12 @@
<exclude name="UseStringBufferForStringAppends"/>
</rule>

<rule ref="category/java/performance.xml/TooFewBranchesForSwitch">
<properties>
<!-- If you have one case only please use a if -->
<property name="minimumNumberCaseForASwitch" value="2"/>
</properties>
</rule>

<rule ref="category/java/security.xml"/>
</ruleset>
3 changes: 3 additions & 0 deletions .github/workflows/broken-links.yml
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,7 @@ permissions:
jobs:
link-checker:
runs-on: ubuntu-latest
timeout-minutes: 15
steps:
- uses: actions/checkout@v4

Expand All @@ -19,6 +20,8 @@ jobs:
- name: Link Checker
id: lychee
uses: lycheeverse/lychee-action@v2
with:
fail: false # Don't fail on broken links, create an issue instead

- name: Find already existing issue
id: find-issue
Expand Down
3 changes: 3 additions & 0 deletions .github/workflows/check-build.yml
Original file line number Diff line number Diff line change
Expand Up @@ -26,6 +26,7 @@ env:
jobs:
build:
runs-on: ubuntu-latest
timeout-minutes: 30

strategy:
matrix:
Expand Down Expand Up @@ -82,6 +83,7 @@ jobs:
checkstyle:
runs-on: ubuntu-latest
if: ${{ github.event_name != 'pull_request' || !startsWith(github.head_ref, 'renovate/') }}
timeout-minutes: 15

strategy:
matrix:
Expand All @@ -104,6 +106,7 @@ jobs:
pmd:
runs-on: ubuntu-latest
if: ${{ github.event_name != 'pull_request' || !startsWith(github.head_ref, 'renovate/') }}
timeout-minutes: 15

strategy:
matrix:
Expand Down
5 changes: 5 additions & 0 deletions .github/workflows/release.yml
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,7 @@ permissions:
jobs:
check-code:
runs-on: ubuntu-latest
timeout-minutes: 30
steps:
- uses: actions/checkout@v4

Expand Down Expand Up @@ -48,6 +49,7 @@ jobs:
prepare-release:
runs-on: ubuntu-latest
needs: [check-code]
timeout-minutes: 10
outputs:
upload_url: ${{ steps.create_release.outputs.upload_url }}
steps:
Expand Down Expand Up @@ -109,6 +111,7 @@ jobs:
publish-maven:
runs-on: ubuntu-latest
needs: [prepare-release]
timeout-minutes: 60
steps:
- uses: actions/checkout@v4

Expand Down Expand Up @@ -140,6 +143,7 @@ jobs:
publish-pages:
runs-on: ubuntu-latest
needs: [prepare-release]
timeout-minutes: 15
steps:
- uses: actions/checkout@v4

Expand Down Expand Up @@ -169,6 +173,7 @@ jobs:
after-release:
runs-on: ubuntu-latest
needs: [publish-maven]
timeout-minutes: 10
steps:
- uses: actions/checkout@v4

Expand Down
2 changes: 2 additions & 0 deletions .github/workflows/sonar.yml
Original file line number Diff line number Diff line change
Expand Up @@ -27,6 +27,7 @@ jobs:
token-check:
runs-on: ubuntu-latest
if: ${{ !(github.event_name == 'pull_request' && startsWith(github.head_ref, 'renovate/')) }}
timeout-minutes: 5
outputs:
hasToken: ${{ steps.check-token.outputs.has }}
steps:
Expand All @@ -40,6 +41,7 @@ jobs:
runs-on: ubuntu-latest
needs: token-check
if: ${{ needs.token-check.outputs.hasToken }}
timeout-minutes: 30
steps:
- uses: actions/checkout@v4
with:
Expand Down
1 change: 1 addition & 0 deletions .github/workflows/sync-labels.yml
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,7 @@ permissions:
jobs:
labels:
runs-on: ubuntu-latest
timeout-minutes: 10
steps:
- uses: actions/checkout@v4
with:
Expand Down
1 change: 1 addition & 0 deletions .github/workflows/test-deploy.yml
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,7 @@ env:
jobs:
publish-maven:
runs-on: ubuntu-latest
timeout-minutes: 60
steps:
- uses: actions/checkout@v4

Expand Down
2 changes: 2 additions & 0 deletions .github/workflows/update-from-template.yml
Original file line number Diff line number Diff line change
Expand Up @@ -31,6 +31,7 @@ permissions:
jobs:
update:
runs-on: ubuntu-latest
timeout-minutes: 60
outputs:
update_branch_merged_commit: ${{ steps.manage-branches.outputs.update_branch_merged_commit }}
create_update_branch_merged_pr: ${{ steps.manage-branches.outputs.create_update_branch_merged_pr }}
Expand Down Expand Up @@ -180,6 +181,7 @@ jobs:
needs: [update]
if: needs.update.outputs.create_update_branch_merged_pr == 1
runs-on: ubuntu-latest
timeout-minutes: 60
steps:
- uses: actions/checkout@v4
with:
Expand Down
2 changes: 1 addition & 1 deletion .idea/checkstyle-idea.xml

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

5 changes: 5 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,3 +1,8 @@
## 2.4.0
* PointStyle can also contain non-string constants #280
* Use ``CoreInteractionOptions`` for ``Options#interaction`` and ``Options#hover`` #281
* Updated dependencies

## 2.3.1
* Synced ``LineOptions/DataSet`` ``stepped`` and ``tension`` with ChartJS source #262
* Updated dependencies
Expand Down
4 changes: 2 additions & 2 deletions chartjs-java-model-demo/pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -7,11 +7,11 @@
<parent>
<groupId>software.xdev</groupId>
<artifactId>chartjs-java-model-root</artifactId>
<version>2.3.2-SNAPSHOT</version>
<version>2.4.0-SNAPSHOT</version>
</parent>

<artifactId>chartjs-java-model-demo</artifactId>
<version>2.3.2-SNAPSHOT</version>
<version>2.4.0-SNAPSHOT</version>
<packaging>jar</packaging>

<organization>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,7 @@ private static void createAndOpenTestFile(final Chart<?, ?, ?> chart)
+ "<html lang='en'>\n"
+ "\t<head>\n"
+ "\t\t<meta charset='UTF-8'>\n"
+ "\t\t<script src=\"https://cdn.jsdelivr.net/npm/[email protected].5/dist/chart.umd.js\"></script>\n"
+ "\t\t<script src=\"https://cdn.jsdelivr.net/npm/[email protected].6/dist/chart.umd.js\"></script>\n"
+ "\t</head>\n"
+ "\t<body>\n"
+ "\t\t<canvas id='c' style='border:1px solid #555;'></canvas>\n"
Expand Down
30 changes: 15 additions & 15 deletions chartjs-java-model/pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@

<groupId>software.xdev</groupId>
<artifactId>chartjs-java-model</artifactId>
<version>2.3.2-SNAPSHOT</version>
<version>2.4.0-SNAPSHOT</version>
<packaging>jar</packaging>

<name>chartjs-java-model</name>
Expand Down Expand Up @@ -50,7 +50,7 @@

<slf4j-version>2.0.16</slf4j-version>
<log4j-version>2.24.1</log4j-version>
<testcontainers-version>1.20.2</testcontainers-version>
<testcontainers-version>1.20.3</testcontainers-version>

<!-- by default run no tests as Docker is required -->
<skipTests>true</skipTests>
Expand Down Expand Up @@ -95,7 +95,7 @@
<dependency>
<groupId>com.fasterxml.jackson.core</groupId>
<artifactId>jackson-databind</artifactId>
<version>2.18.0</version>
<version>2.18.1</version>
</dependency>

<!-- Tests -->
Expand Down Expand Up @@ -129,7 +129,7 @@
<dependency>
<groupId>org.junit.jupiter</groupId>
<artifactId>junit-jupiter</artifactId>
<version>5.11.2</version>
<version>5.11.3</version>
<scope>test</scope>
</dependency>

Expand Down Expand Up @@ -162,15 +162,15 @@
<dependency>
<groupId>software.xdev</groupId>
<artifactId>testcontainers-selenium</artifactId>
<version>1.0.2</version>
<version>1.1.0</version>
<scope>test</scope>
</dependency>

<!-- Selenium -->
<dependency>
<groupId>org.seleniumhq.selenium</groupId>
<artifactId>selenium-chrome-driver</artifactId>
<version>4.25.0</version>
<version>4.26.0</version>
<scope>test</scope>
<exclusions>
<!-- Tracing is not needed -->
Expand All @@ -193,7 +193,7 @@
<plugin>
<groupId>org.apache.maven.plugins</groupId>
<artifactId>maven-project-info-reports-plugin</artifactId>
<version>3.7.0</version>
<version>3.8.0</version>
</plugin>
</plugins>
</pluginManagement>
Expand Down Expand Up @@ -241,7 +241,7 @@
<plugin>
<groupId>org.apache.maven.plugins</groupId>
<artifactId>maven-javadoc-plugin</artifactId>
<version>3.10.1</version>
<version>3.11.1</version>
<executions>
<execution>
<id>attach-javadocs</id>
Expand Down Expand Up @@ -274,7 +274,7 @@
<plugin>
<groupId>org.apache.maven.plugins</groupId>
<artifactId>maven-surefire-plugin</artifactId>
<version>3.5.1</version>
<version>3.5.2</version>
<configuration>
<skipTests>${skipTests}</skipTests>
</configuration>
Expand Down Expand Up @@ -355,12 +355,12 @@
<plugin>
<groupId>org.apache.maven.plugins</groupId>
<artifactId>maven-checkstyle-plugin</artifactId>
<version>3.5.0</version>
<version>3.6.0</version>
<dependencies>
<dependency>
<groupId>com.puppycrawl.tools</groupId>
<artifactId>checkstyle</artifactId>
<version>10.18.2</version>
<version>10.20.1</version>
</dependency>
</dependencies>
<configuration>
Expand All @@ -385,7 +385,7 @@
<plugin>
<groupId>org.apache.maven.plugins</groupId>
<artifactId>maven-pmd-plugin</artifactId>
<version>3.25.0</version>
<version>3.26.0</version>
<configuration>
<includeTests>true</includeTests>
<printFailingErrors>true</printFailingErrors>
Expand All @@ -397,12 +397,12 @@
<dependency>
<groupId>net.sourceforge.pmd</groupId>
<artifactId>pmd-core</artifactId>
<version>7.6.0</version>
<version>7.7.0</version>
</dependency>
<dependency>
<groupId>net.sourceforge.pmd</groupId>
<artifactId>pmd-java</artifactId>
<version>7.6.0</version>
<version>7.7.0</version>
</dependency>
</dependencies>
</plugin>
Expand All @@ -414,7 +414,7 @@
<plugin>
<groupId>org.apache.maven.plugins</groupId>
<artifactId>maven-jxr-plugin</artifactId>
<version>3.5.0</version>
<version>3.6.0</version>
</plugin>
</plugins>
</reporting>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,6 @@
import java.util.List;

import software.xdev.chartjs.model.enums.BorderSkipped;
import software.xdev.chartjs.model.enums.PointStyle;
import software.xdev.chartjs.model.objects.OptionalArray;


Expand All @@ -35,7 +34,7 @@ public class BarDataset extends BackgroundBorderHoverDataset<BarDataset, Number>
protected Object barThickness;
protected Number maxBarThickness;
protected Number minBarLength;
protected PointStyle pointStyle;
protected Object pointStyle;
protected Boolean grouped;

protected final List<BorderSkipped> borderSkipped = new OptionalArray<>();
Expand Down Expand Up @@ -123,12 +122,12 @@ public BarDataset setMinBarLength(final Number minBarLength)
return this;
}

public PointStyle getPointStyle()
public Object getPointStyle()
{
return this.pointStyle;
}

public BarDataset setPointStyle(final PointStyle pointStyle)
public BarDataset setPointStyle(final Object pointStyle)
{
this.pointStyle = pointStyle;
return this;
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,6 @@
import java.util.List;

import software.xdev.chartjs.model.datapoint.BubbleDataPoint;
import software.xdev.chartjs.model.enums.PointStyle;
import software.xdev.chartjs.model.objects.OptionalArray;


Expand All @@ -32,7 +31,7 @@ public class BubbleDataset extends BackgroundBorderHoverDataset<BubbleDataset, B

protected final List<Integer> hoverRadius = new OptionalArray<>();

protected PointStyle pointStyle;
protected Object pointStyle;

@Override
protected String defaultType()
Expand Down Expand Up @@ -95,12 +94,12 @@ public List<Integer> getHoverRadius()
return this.hoverRadius;
}

public PointStyle getPointStyle()
public Object getPointStyle()
{
return this.pointStyle;
}

public BubbleDataset setPointStyle(final PointStyle pointStyle)
public BubbleDataset setPointStyle(final Object pointStyle)
{
this.pointStyle = pointStyle;
return this;
Expand Down
Loading