Skip to content

Enable use of property music.skip for skipping#11

Merged
AB-xdev merged 1 commit intoxdev-software:developfrom
runeflobakk:enable-skip-property
Feb 14, 2025
Merged

Enable use of property music.skip for skipping#11
AB-xdev merged 1 commit intoxdev-software:developfrom
runeflobakk:enable-skip-property

Conversation

@runeflobakk
Copy link
Contributor

@runeflobakk runeflobakk commented Jan 23, 2025

Did not see myself proposing a contribution to this plugin, but here we are 😆

With @Parameter(property="music.skip") for the skip-parameter in MusicMojo, this enables the troller to subtly disable accidentally blasting the music in the office space while waiting for the trollees to be trolled, while avoiding being self-trolled.

E.g. by using the command:

mvn install -Dmusic.skip

or even set it globally with the MAVEN_OPTS environment variable:

MAVEN_OPTS="-Dmusic.skip=true"

Running mvn help:describe -Dplugin=music -Dgoal=music -Ddetail in a project with the plugin configured will show the following addition to the skip parameter:

  [INFO] --- help:3.5.1:describe (default-cli) @ signering ---
  [INFO] Mojo: 'music:music'
  music:music
    Description: (no description available)
    Implementation: software.xdev.maven.music.MusicMojo
    Language: java
    Bound to phase: validate

    Available parameters:

      background
        Plays the music in the background (non-blocking) If this set to false,
        repeat will be forcefully set to false
    (...)
      skip
>       User property: music.skip
        (no description available)

@hernil
Copy link

hernil commented Jan 23, 2025

As a victim, or trollee if you want, I approve of this 🙌

@runeflobakk runeflobakk changed the title Enable property music.skip for skipping Enable use of property music.skip for skipping Jan 23, 2025
Copy link
Member

@AB-xdev AB-xdev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Thank you for the contribution :)

@AB-xdev AB-xdev merged commit 91ead6c into xdev-software:develop Feb 14, 2025
5 of 6 checks passed
@runeflobakk runeflobakk deleted the enable-skip-property branch February 14, 2025 12:39
@AB-xdev AB-xdev self-assigned this Feb 14, 2025
xdev-gh-bot pushed a commit that referenced this pull request Nov 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants