Enable use of property music.skip for skipping#11
Merged
AB-xdev merged 1 commit intoxdev-software:developfrom Feb 14, 2025
Merged
Enable use of property music.skip for skipping#11AB-xdev merged 1 commit intoxdev-software:developfrom
AB-xdev merged 1 commit intoxdev-software:developfrom
Conversation
|
As a victim, or trollee if you want, I approve of this 🙌 |
AB-xdev
approved these changes
Feb 14, 2025
Member
AB-xdev
left a comment
There was a problem hiding this comment.
LGTM
Thank you for the contribution :)
xdev-gh-bot
pushed a commit
that referenced
this pull request
Nov 24, 2025
Update actions/checkout action to v6
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Did not see myself proposing a contribution to this plugin, but here we are 😆
With
@Parameter(property="music.skip")for theskip-parameter inMusicMojo, this enables the troller to subtly disable accidentally blasting the music in the office space while waiting for the trollees to be trolled, while avoiding being self-trolled.E.g. by using the command:
or even set it globally with the
MAVEN_OPTSenvironment variable:Running
mvn help:describe -Dplugin=music -Dgoal=music -Ddetailin a project with the plugin configured will show the following addition to theskipparameter:[INFO] --- help:3.5.1:describe (default-cli) @ signering --- [INFO] Mojo: 'music:music' music:music Description: (no description available) Implementation: software.xdev.maven.music.MusicMojo Language: java Bound to phase: validate Available parameters: background Plays the music in the background (non-blocking) If this set to false, repeat will be forcefully set to false (...) skip > User property: music.skip (no description available)