Skip to content

Commit c4de50c

Browse files
committed
Fix PMD
1 parent 6f15362 commit c4de50c

File tree

5 files changed

+8
-2
lines changed

5 files changed

+8
-2
lines changed

vaadin-grid-filter/src/main/java/software/xdev/vaadin/FilterComponent.java

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -86,6 +86,7 @@
8686
*
8787
* @param <T> Grid type
8888
*/
89+
@SuppressWarnings("PMD.GodClass") // Fixed in v2
8990
public class FilterComponent<T> extends Composite<VerticalLayout> implements BeforeEnterObserver
9091
{
9192
public static final String CHIP_BADGE_FILTER_COMPONENT = "chipFilterComponent";
@@ -432,6 +433,7 @@ private void deactivateDeleteButtonFromChipComponents(
432433
/**
433434
* Format chip badge input text for LocalDate and LocalDateTime.
434435
*/
436+
@SuppressWarnings("PMD.CognitiveComplexity") // Fixed in v2
435437
private void formatLocalDateChipBadgeText(final ChipBadge<FilterCondition<T, ?>> chipBadge)
436438
{
437439
if(this.dateRangePickerQuery.isVisible()
@@ -759,6 +761,7 @@ private void setEnumSelectValues(final FilterField<T, ?> filterField)
759761
.toList());
760762
}
761763

764+
@SuppressWarnings({"PMD.CognitiveComplexity", "PMD.CollapsibleIfStatements"}) // Fixed in v2
762765
private void createConditionsFromQueryParameters()
763766
{
764767
for(int i = 0; i < this.queryFieldList.size(); i++)

vaadin-grid-filter/src/main/java/software/xdev/vaadin/comparators/EqualComparator.java

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -62,6 +62,7 @@ public boolean isApplicable(final Class<?> clazz)
6262
|| Boolean.class.isAssignableFrom(clazz);
6363
}
6464

65+
@SuppressWarnings({"PMD.CognitiveComplexity", "PMD.NPathComplexity"}) // Fixed in v2
6566
@Override
6667
public <B, T> Predicate<B> compare(final ValueProvider<B, T> provider, final String searchQuery)
6768
{

vaadin-grid-filter/src/main/java/software/xdev/vaadin/comparators/IsBetweenComparator.java

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -60,6 +60,7 @@ public boolean isApplicable(final Class<?> clazz)
6060
return LocalDate.class.isAssignableFrom(clazz);
6161
}
6262

63+
@SuppressWarnings("PMD.PreserveStackTrace") // Fixed in v2
6364
@Override
6465
public <B, T> Predicate<B> compare(final ValueProvider<B, T> provider, final String searchQuery)
6566
{

vaadin-grid-filter/src/main/java/software/xdev/vaadin/comparators/NotEqualComparator.java

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -61,7 +61,8 @@ public boolean isApplicable(final Class<?> clazz)
6161
|| Enum.class.isAssignableFrom(clazz)
6262
|| Boolean.class.isAssignableFrom(clazz);
6363
}
64-
64+
65+
@SuppressWarnings({"PMD.CognitiveComplexity", "PMD.NPathComplexity"}) // Fixed in v2
6566
@Override
6667
public <B, T> Predicate<B> compare(final ValueProvider<B, T> provider, final String searchQuery)
6768
{

vaadin-grid-filter/src/main/java/software/xdev/vaadin/comparators/utl/DateHelper.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -38,7 +38,7 @@ public static DateTimeFormatter getDatePattern(final DatePicker.DatePickerI18n d
3838

3939
for(final String pattern : datePickerI18n.getDateFormats())
4040
{
41-
patternString.append("[").append(pattern).append("]");
41+
patternString.append('[').append(pattern).append(']');
4242
}
4343

4444
return DateTimeFormatter.ofPattern(patternString.toString());

0 commit comments

Comments
 (0)