Allow 'parseArgs' and 'numOptArgs' in environments

[larsgw]

Close #13

[larsgw]

Would there be potential issues with this? If no, I can enable it for the tabular environ.

[stale]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

[stale]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

[stale]

Closing this issue after a prolonged period of inactivity.

[stale]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

[stale]

Closing this issue after a prolonged period of inactivity.

[stale]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

[larsgw]

Commenting to keep it open.

[stale]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

[larsgw]

Commenting to keep it open.

[stale]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

[larsgw]

Commenting to keep it open.

[stale]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

[larsgw]

Commenting to keep it open.

[stale]

Closing this issue after a prolonged period of inactivity.

[larsgw]

?

[xemlock]

Hi @larsgw, apologies for the delayed response. Thanks for your contribution!
Unfortunately the proposed changes work incorrectly. For the following (valid) input:

\begin{tabular}[t]{|c|c|c|}
 cell1 & cell2 & cell3
\end{tabular}

we get garbled result:

\begin{tabular}{{[}}
t{]}{|c|c|c|} cell1 & cell2 & cell3
\end{tabular}

when rendering via PhpLatex_Renderer_Abstract::toLatex, which suggests that something is wrong with building the document tree.

[larsgw]

Part of this is because I have not updated the tabular environ yet in library/PhpLatex/Utils/environs.php, so that's the behavior without numOptArgs. With, it becomes the following, which still isn't ideal:

\begin{tabular}
[{t}]{|c|c|c|} cell1 & cell2 & cell3 
\end{tabular}

[larsgw]

I'll update environs.php as best I can, and take a look at the document tree.

[xemlock]

Part of this is because I have not updated the tabular environ yet.

Yes, you're right! I didn't catch that.

As for failing tests, just add single space before cell1 in the expected output (so that it matches other environment tests) and we're good to go.

[larsgw]

Not sure why I didn't run it again after the last changes... Also, apparently there should be a space afterwards too.

[larsgw]

That's strange, this passes the tests locally (php 8.2).

[xemlock]

There shouldn't be space after any more (because of commit f4d3604). Not sure what commit your PR branch originates from, but if you'd rebase it (or merge) from master, it should start working.

[xemlock]

You can pull recent changes with the following commands in your terminal:

git remote add xemlock git@github.com:xemlock/php-latex.git
git fetch xemlock master
git merge xemlock/master

[larsgw]

Oh, that makes sense, thank you.

[xemlock]

Thanks!