-
-
Notifications
You must be signed in to change notification settings - Fork 382
Adjustable display refresh rate (in the UI layer) #2400
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
|
only fixes Blood Wake other game are unaffected. Note only tested Antz Extreme Racing |
|
Would fix #1011 |
|
FYI, there's a force push because I revised the commit names, applied clang formatting, and merged a few commits that accomplished very similar things |
|
Out of curiosity, how does this compare to the display rate override setting from #2028? |
@Calinou I was unaware of that code what I wrote my version. I did look over it afterwards though. The display rate adjustment is performed in the same region of code. #2028 uses the current default of 60fps as a baseline and introduces an adjusting coefficient to scale the frame expiration duration on each iteration. My approach replaces the constant expiration time of They also chose to store the setting as a reciprocal of the coefficient and calculate both the reciprocal and multiplication of the time scaling on each frame. This isn't really expensive, but it is unnecessary and weird. Sorry to be snobby about meaningless optimization and semi-arbitrary code quality. |
This PR replaces the current 60Hz refresh rate cap in the UI layer with a variable cap specified by the config.
This PR is paired to issue #2399 but also provides a hot patch to many of the over-speeding issues. This provides a definitive work-around for #2017 that can be used while watching cut scenes. It also may provide a solution to some of the issues experienced in #1099.
Here are screenshots of the UI changes to add this control.
Options in MenuBar: (If you look at the fps graph you can see I was changing it too)

Options in Settings: (The custom FPS slider is hidden when the FPS is set to anything besides custom)
