-
-
Notifications
You must be signed in to change notification settings - Fork 382
nv2a: Route DMA access through mem callbacks #2514
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
nv2a: Route DMA access through mem callbacks #2514
Conversation
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
Confirmed Hill 30 makes it into the game on M3/macOS, I don't recall ever getting past the main menu without playing around in the debugger (likely changing timing enough to bypass the bug). Once this PR is merged it'd be good to get issues filed for those games, but it does indeed seem that this resolves the currently reported problem. |
This comment was marked as off-topic.
This comment was marked as off-topic.
|
@antoniodesousa Do you have Steel Battalion |
Let's keep this comment thread focused on the deadlocks/crashes that appear to be fixed by this PR; if fixing an existing deadlock allows the game to progress and exposes other issues let's file new bugs (making note that this PR is necessary to repro) or just add comments to the existing bugs. It gets very confusing if we start trying to chase down multiple issues that (hopefully) are not directly related to this change. |
|
Ok, no problem it was just in case a related to issues 326 as you already have a pr fix for it. The 2 pr together could resolve assertion on amd i don't know. I hide the comment and post on respective issue about the assertion. |
|
No need to hide the comment, I just don't want the PR thread to turn into a debugging discussion for issues (unless they're suspected to be caused by the PR) |
|
About my previous report, it only crashes when using the M8+ bios. Still not related to the current PR. |
|
Thank for confirmation. As when you mention the crashing on amd, I ask around and you where the only one matching that behaviour, amd or not |
|
May resolve #1471 as well |
This change prevents direct memory buffer access to callback protected regions, forcing them to take the slow path that is protected by the callbacks. As a result, DMA access to GPU surfaces will properly trigger synchronization with the associated GPU buffer. Fixes xemu-project#1238
60057f9 to
a226b82
Compare

This change prevents direct memory buffer access to callback protected regions, forcing them to take the slow path that is protected by the callbacks. As a result, DMA access to GPU surfaces will properly trigger synchronization with the associated GPU buffer.
Fixes #1238
Fixes #583
Fixes #1264
Apparently fixes #2333