Conversation
config.h
Outdated
| #include "config_windows_x86_64.h" | ||
| #elif defined(__gnu_linux__) | ||
| #include "config_linux_x86_64.h" | ||
| #elif defined(TARGET_OS_MAC) && TARGET_OS_MAC |
There was a problem hiding this comment.
Both defined(TARGET_OS_MAC) and TARGET_OS_MAC are not required, all non-existent preprocessor identifiers are expanded to 0 in preprocessor conditionals. If this is defined as always 1 when true (rather than just to an empty value — and according to what I can find, it is indeed defined as 1), just a TARGET_OS_MAC check is enough.
| -- libavcodec/x86/Makefile: | ||
| -- OBJS: | ||
| filter({"platforms:Android_x86_64 or platforms:Linux or platforms:Windows"}) | ||
| filter({"platforms:Android_x86_64 or platforms:Linux or platforms:Mac or platforms:Windows"}) |
There was a problem hiding this comment.
This filter (here and in 2 more places) can be shortened to platforms:Android_x86_64 or Linux or Mac or Windows.
There was a problem hiding this comment.
But its autogenerated and the generator doesnt know about that
|
I would prefer to have three separate commits (like seen in commit history):
This will make it easier to rebase our changes to newer ffmpeg and squash some commits to the premake generator for example |
conradev
force-pushed
the
macos-support
branch
from
e0390ab to
e07c38c
Compare
3 participants
I will be adding
platforms:Macin an upcoming PR to xenia