ACC-2584: fix If-Match and If-None-Match validation for GET on entity item and to-one relation endpoints

[NielsCW]

this breaks behavior of If-None-Match on entity item requests (it was not supported on relation requests). Fixed in this PR as well.

[vierbergenlars]

Hmm, I'm not sure how I feel about conditionally ignoring the If-None-Match header here.

If it's not combined with the explicit check in the body, the requested version check is not performed, and that's not really obvious from the code in the controller.

Did you take a look at the content controller code?

There is first a check done with WebRequest#checkNotModified(); and then a VersionConstraint check after it. Moving that into an utility method that is called from the 3 places might be nicer?

contentgrid-appserver/contentgrid-appserver-rest/src/main/java/com/contentgrid/appserver/rest/property/ContentRestController.java

Lines 103 to 115 in 86ee65f

	var eTag = calculateETag(content);
	// First check not-modified for a 304 response before performing If-Match validation (with a 412 response)
	if(webRequest.checkNotModified(eTag)) {
	return null; // The response headers inside webRequest are modified as side effect
	}
	if(!versionConstraint.isSatisfiedBy(content.getVersion())) {
	throw new UnsatisfiedVersionException(
	content.getVersion(),
	versionConstraint
	);
	}

[rschev]

I think this javadoc should be slightly more like the javadoc of webRequest.checkNotModified(). The way it's phrased here makes it sound like the response has already happened.

Checks whether the requested entity's version matches the versionConstraint.
Returns true when it matches, false when the entity is newer. This will also
set the webRequest's HTTP response status to 304 and 200, respectively.

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
100.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud