Skip to content

Reduce logspam of exception stacktraces for logs that can't be read #66

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
vierbergenlars merged 1 commit into from
Oct 17, 2025
Merged

Reduce logspam of exception stacktraces for logs that can't be read #66

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 10 additions & 2 deletions ...s/src/main/java/com/contentgrid/junit/jupiter/k8s/wait/resource/PodAwaitableResource.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,7 +50,7 @@ private Stream<? extends LogLine> readContainer(PodResource resource, String con
.getLogReader()
);
} catch(KubernetesClientException exception) {
log.warn("Failed to read logs from {} container {}", this, containerName, exception);
logReadException(containerName, exception);
}

try {
Expand All @@ -62,11 +62,19 @@ private Stream<? extends LogLine> readContainer(PodResource resource, String con
.getLogReader()
);
} catch(KubernetesClientException exception) {
log.warn("Failed to read logs from {} container {}", this, containerName, exception);
logReadException(containerName, exception);
}
return logReaders.stream().flatMap(logReader -> readLogs(containerName, logReader));
}

private void logReadException(String containerName, KubernetesClientException exception) {
if(log.isTraceEnabled()) {
log.warn("Failed to read logs from {} container {}", this, containerName, exception);
} else {
log.warn("Failed to read logs from {} container {}: {}", this, containerName, exception.getStatus().getMessage());
}
}

private Stream<LogLine> readLogs(String containerName, Reader logReader) {
return new BufferedReader(logReader).lines()
.map(line -> createLogLine(line, containerName));
Expand Down