improved section (slice) tool and marquee selection tool#240
Open
ahhhchuen wants to merge 4 commits intoxeokit:masterfrom
Open
improved section (slice) tool and marquee selection tool#240ahhhchuen wants to merge 4 commits intoxeokit:masterfrom
ahhhchuen wants to merge 4 commits intoxeokit:masterfrom
Conversation
ahhhchuen
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Existing section (slice) tool mistakenly read the mouse-up event from view spinning to create unexpected new section planes. This pull fix this in src\toolbar\SectionTool.js
Existing marquee selection tool did not work correctly then the height/width of the canvas larger than 1. The pull fix this in src\toolbar\MarqueeSelectionTool.js & OrthoMode.js