Fixed duplicate loading of .obj model causing material ID errors#1405
Open
erikwski wants to merge 4 commits intoxeokit:masterfrom
Open
Fixed duplicate loading of .obj model causing material ID errors#1405erikwski wants to merge 4 commits intoxeokit:masterfrom
erikwski wants to merge 4 commits intoxeokit:masterfrom
Conversation
…odeType + materialId
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I'm excited to make my first contribution to the project!
This pull request addresses the issue described in the closed issue: #1403, where loading an .obj model could result in the creation of unnecessary "Default" materials or duplicate materials.
I've implemented a solution based on approaches used in my previous projects, which effectively prevents these issues.
Key changes:
Testing:
I've thoroughly tested this solution in my local environment to ensure it resolves the issue without introducing any regressions.
I welcome any feedback or suggestions you may have.
Thank you for your time!