[FIX] SceneModelEntity primitive count broken (NaN) #1964
Open
Kurtil wants to merge 1 commit intoxeokit:masterfrom
Open
[FIX] SceneModelEntity primitive count broken (NaN) #1964Kurtil wants to merge 1 commit intoxeokit:masterfrom
Kurtil wants to merge 1 commit intoxeokit:masterfrom
Conversation
use mesh.numTriangles instead of unknown mesh.numPrimitives
Collaborator
|
Hi @Kurtil, |
Contributor
Author
|
Hi @MichalDybizbanskiCreoox , I managed to reproduce the problem using the |
Collaborator
|
Thank you @Kurtil, we've created an internal ticket and will investigate the issue. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Use
mesh.numTrianglesinstead of unknownmesh.numPrimitivesto computesceneModelEntity.numPrimitives. Maybe it works in some scenario ifnumPrimitiveswas added by parser or something else, but in my case it was broken loading LAZ (point cloud) models. Indeed, assceneModelMeshisundefined, the computednumPrimitivesisNaN.