Skip to content

Update scala-library to 2.12.21 #609

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
xerial merged 1 commit into from
Jan 2, 2026
Merged

Update scala-library to 2.12.21 #609

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion build.sbt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ enablePlugins(SbtTwirl)
enablePlugins(SbtPlugin)

val SCALA_3 = "3.7.4"
val SCALA_2 = "2.12.20"
val SCALA_2 = "2.12.21"
ThisBuild / crossScalaVersions := List(SCALA_3, SCALA_2)

pluginCrossBuild / sbtVersion := {
Expand Down
2 changes: 1 addition & 1 deletion src/sbt-test/sbt-pack/copy-dependencies/build.sbt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
ThisBuild / scalaVersion := "2.13.16"

val commonSettings = Seq(
scalaVersion := "2.12.20",
scalaVersion := "2.12.21",
Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist bot Dec 12, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

To avoid hardcoding the Scala version and improve maintainability, consider reading it from a system property. This would allow you to set the version in your main build.sbt's scriptedLaunchOpts and have it propagate to your scripted tests automatically, ensuring consistency. For this to work, you would need to add a property like "-Dscala.version.2.12=" + SCALA_2 to scriptedLaunchOpts in the root build.sbt.

  scalaVersion               := sys.props.get("scala.version.2.12").getOrElse("2.12.21"),

version := "0.1",
crossPaths := false,
packCopyDependenciesTarget := target.value / "WEB-INF/lib"
Expand Down
Loading