Skip to content

Update sbt, scripted-plugin to 1.12.1#617

Closed
xerial-bot wants to merge 1 commit intomainfrom
update/sbt-1.12.1
Closed

Update sbt, scripted-plugin to 1.12.1#617
xerial-bot wants to merge 1 commit intomainfrom
update/sbt-1.12.1

Conversation

@xerial-bot
Copy link
Copy Markdown
Collaborator

About this PR

📦 Updates

from 1.11.7 to 1.12.1

📜 GitHub Release Notes - Version Diff

Usage

Please merge!

I'll automatically update this PR to resolve conflicts as long as you don't change it yourself.

If you'd like to skip this version, you can just close this PR. If you have any feedback, just mention me in the comments below.

Configure Scala Steward for your repository with a .scala-steward.conf file.

Have a fantastic day writing Scala!

⚙ Adjust future updates

Add this to your .scala-steward.conf file to ignore future updates of this dependency:

updates.ignore = [ { groupId = "org.scala-sbt" } ]

Or, add this to slow down future updates of this dependency:

dependencyOverrides = [{
  pullRequests = { frequency = "30 days" },
  dependency = { groupId = "org.scala-sbt" }
}]
labels: library-update, early-semver-minor, semver-spec-minor, version-scheme:early-semver, commit-count:1

@gemini-code-assist
Copy link
Copy Markdown
Contributor

Summary of Changes

Hello @xerial-bot, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request focuses on upgrading the project's build infrastructure by updating the sbt version. This ensures the project leverages the latest features, performance enhancements, and bug fixes available in the newer sbt release, contributing to a more robust and efficient development environment.

Highlights

  • sbt Version Update: The core sbt build tool and the scripted-plugin have been updated from version 1.11.7 to 1.12.1.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request from Scala Steward correctly updates the sbt version from 1.11.7 to 1.12.1. The changes are straightforward. My review highlights a potential maintainability improvement: ensuring sbt version consistency across all scripted test projects. One test project was found to be using an older, different sbt version, which might be unintentional.

@@ -1 +1 @@
sbt.version=1.11.7
sbt.version=1.12.1
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

This sbt version update is correct. However, I noticed that another scripted test project is on a different, older sbt version. The file src/sbt-test/sbt-pack/jvm-version-opts/project/build.properties still uses sbt.version=1.10.11. For consistency and easier maintenance, consider updating all test projects to use the same sbt version (1.12.1). If this specific test needs to run on an older sbt version for compatibility reasons, it would be helpful to add a comment in that file explaining why.

@xerial-bot
Copy link
Copy Markdown
Collaborator Author

Superseded by #618.

@xerial-bot xerial-bot closed this Feb 4, 2026
@xerial-bot xerial-bot deleted the update/sbt-1.12.1 branch February 4, 2026 08:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant