Skip to content

Add JAR integration test for JDK compatibility #704

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
xerial merged 4 commits into from
Nov 24, 2025
+95 −0
Merged

Add JAR integration test for JDK compatibility #704

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
86d0cbe
Add Enable-Native-Access manifest attribute for JDK 24+
xerial Nov 24, 2025
85056bf
Add integration test for JAR manifest and native access
xerial Nov 24, 2025
98f92e5
Clean up and finalize integration test
xerial Nov 24, 2025
520bf51
Remove unnecessary manifest check from integration test
xerial Nov 24, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions build.sbt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -106,6 +106,11 @@ libraryDependencies ++=

enablePlugins(SbtOsgi)

// Add Enable-Native-Access manifest attribute for JDK 24+ (JEP 472)
packageOptions := Seq(
Package.ManifestAttributes("Enable-Native-Access" -> "ALL-UNNAMED")
)
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot Nov 24, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

While this might work in the current configuration, using := overwrites any previously defined package options. It is safer and more idiomatic in sbt to append to sequence-based settings like packageOptions using ++=. This will prevent potential conflicts with other plugins (like the sbt-osgi plugin enabled in this project) or other settings that might also be adding manifest attributes.

packageOptions ++= Seq(
  Package.ManifestAttributes("Enable-Native-Access" -> "ALL-UNNAMED")
)


osgiSettings

OsgiKeys.exportPackage :=
Expand Down
Loading