Conversation
Contributor
|
Cool! I looked at some of the changes in lib/core/ and it looks good. Not a proper review, but I think it looks promising and is exactly what I want in #55! |
xhtmlboi
approved these changes
Nov 27, 2025
Owner
xhtmlboi
left a comment
xhtmlboi
left a comment
There was a problem hiding this comment.
Thanks a lot!
I am strongly in favor of merging this soon as possible :)
lib/core/action.ml
Outdated
| let* () = Eff.write_file ~on path sexp_str in | ||
| Eff.log ~src:Eff.yocaml_log_src ~level:`Debug @@ Lexicon.cache_stored path | ||
|
|
||
| let remove_residuals ?(on = `Target) ~target cache = |
Owner
There was a problem hiding this comment.
Why does it make sense to check residuals on other thing than Target?
| [INFO]./residuals_build/5.txt deleted! | ||
| [DEBUG]Cache stored in `./residuals_build/cache` | ||
|
|
||
| $ ls residuals_build |
Owner
There was a problem hiding this comment.
Can you, in the test, re-run the generation?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This patch proposes tracking artifacts created by YOCaml to enable the implementation of a new action:
Action.remove_residuals, which allows files that were not created by YOCaml to be deleted.This should fix #55 and simplify Kane's development.
(cc @reynir)