Show detailed diagnostics for 500 server errors#116
Conversation
|
So cool ! I review soon as possible! |
Thanks! |
gr-im
left a comment
There was a problem hiding this comment.
Excellent ! Thanks a lot !
xhtmlboi
left a comment
There was a problem hiding this comment.
Hi !
Thanks for the contribution!
There is two missing part:
- https://github.com/Linda-Njau/yocaml/blob/server-error/plugins/yocaml_eio/server.ml#L62 there's also a server inside
yocaml-eio - a CHANGE entry :)
Thanks it is a valuable improvement!
I`ll make the additions!
Thanks : ) |
|
The code looks fine to me, thank you, but I'd like to test the feature a little before merging :) I'll do that sometime next week (sorry!). Thanks a million! |
Sure, Thanks : ) |
xhtmlboi
left a comment
There was a problem hiding this comment.
I finally had time to test it! Thank you very much @Linda-Njau! It's very, very good! Well done!
Awesome! Thanks : ) |
This PR improves how provider errors appear in the browser.
raise Exittoraise exnso the original exception reaches the server handler