Skip to content

feat: Add Keyboard Shortcuts and Hollow Pipes implementation#119

Merged
xiangechen merged 1 commit intoxiangechen:mainfrom
rgarmyn:feature/pipes-and-shortcuts
Jan 29, 2026
Merged

feat: Add Keyboard Shortcuts and Hollow Pipes implementation#119
xiangechen merged 1 commit intoxiangechen:mainfrom
rgarmyn:feature/pipes-and-shortcuts

Conversation

@rgarmyn
Copy link
Contributor

@rgarmyn rgarmyn commented Jan 28, 2026

This pull request adds support for a new "Pipe" primitive in the Chili3d project, including its modeling logic, UI integration, keyboard shortcuts, and internationalization. It introduces the PipeNode class for pipe creation, updates the ribbon and command system to include the new primitive, and provides translations and shortcut profiles for consistent user experience.
image

image

Pipe Primitive Feature

  • Added a new PipeNode class in pipe.ts that implements the logic for creating pipe geometries, including support for bend radius, thickness, and hollow pipes. The implementation also handles path filleting and sweep operations.
  • Introduced BendTypeConverter in utils/BendTypeConverter.ts for converting bend type values to user-friendly strings and back.

UI and Command System Integration

  • Added "create.pipe" to the default ribbon in ribbon.ts, making the pipe primitive accessible from the UI.
  • Updated CommandUtils with a new getAllCommands method and exported shortcutProfiles for easier command and shortcut management. [1] [2]
  • Integrated default shortcut profiles, including a shortcut for creating pipes (Shift+P), and provided alternative profiles for Revit, Blender, Solidworks, and Creo in shortcutProfiles.ts.
  • Updated RibbonButton to display keyboard shortcuts in tooltips, using the default shortcut profile and observing title changes for dynamic updates. [1] [2] [3]

Internationalization

  • Added new i18n keys and translations for "pipe" and related options (e.g., "bend radius", "bend type") in English, Chinese, and Portuguese. [1] [2] [3] [4] [5] [6] [7] [8] [9]

Core and Export Updates

  • Exported the new pipe.ts from the bodys module for use throughout the application.

@CLAassistant
Copy link

CLAassistant commented Jan 28, 2026

CLA assistant check
All committers have signed the CLA.

@xiangechen xiangechen merged commit f013192 into xiangechen:main Jan 29, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants