fix(keyboardstate.cc): forgotten Win modifier + Qt >= 6.2 optimization#2673
Merged
xiaoyifang merged 1 commit intoxiaoyifang:stagedfrom Jan 12, 2026
Merged
fix(keyboardstate.cc): forgotten Win modifier + Qt >= 6.2 optimization#2673xiaoyifang merged 1 commit intoxiaoyifang:stagedfrom
Win modifier + Qt >= 6.2 optimization#2673xiaoyifang merged 1 commit intoxiaoyifang:stagedfrom
Conversation
Owner
|
xiaoyifang
reviewed
Jan 9, 2026
src/keyboardstate.cc
Outdated
| { | ||
| auto modifiers = QApplication::queryKeyboardModifiers(); | ||
|
|
||
| #if QT_VERSION >= QT_VERSION_CHECK( 6, 2, 0 ) |
Owner
There was a problem hiding this comment.
this should be always true (in current situation). just keep this branch.
Contributor
Author
There was a problem hiding this comment.
I don't see any minimum version required in the CML:
find_package(Qt6 REQUIRED COMPONENTS ${GD_QT_COMPONENTS})
Shall I set it? To what?
Contributor
Author
There was a problem hiding this comment.
I've updated the patch with the minimum required Qt version 6.2
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The original code didn't check for the
Winmodifier. I left the previous implementation untouched1 and rewrote it for Qt 6.2 and later, where theQFlags::testFlags()method was introduced.Footnotes
cuz it doesn't work for me, even updated 🤔 ↩