Skip to content

Fix sqlerror with empty CampaignID #3282

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
movisda wants to merge 1 commit into
base: develop
Choose a base branch
from
+3 −0
Open

Fix sqlerror with empty CampaignID #3282

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions lib/Factory/LayoutFactory.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2582,6 +2582,9 @@
foreach ($this->getStore()->select($sql, []) as $row) {
$campaignIds[] = $row['CampaignID'];
}
if (count($campaignIds) === 0) {
$campaignIds[] = "NULL";

Check failure on line 2586 in lib/Factory/LayoutFactory.php

View workflow job for this annotation

GitHub Actions / phpcs 

String "NULL" does not require double quotes; use single quotes instead
}

$body .= ' AND campaign.CampaignID NOT IN ( ' . implode(',', array_filter($campaignIds)) . ' )
AND layout.layoutID NOT IN (SELECT DISTINCT defaultlayoutid FROM display)
Expand Down
Loading