Skip to content

Conversation

@arrowd
Copy link
Contributor

@arrowd arrowd commented Dec 10, 2025

See individual commits descriptions.

@arrowd
Copy link
Contributor Author

arrowd commented Dec 19, 2025

Ping.

@ximion
Copy link
Owner

ximion commented Dec 19, 2025

The meson stuff and the FreeBSD fixes can go in as-is, but I haven't had time to think through the path changes, hence the delay (they do look sensible at first glance though).

@arrowd
Copy link
Contributor Author

arrowd commented Dec 28, 2025

Oh, maybe I misunderstood what PackageIndex::dataPrefix() is supposed to return. I made it return a prefix value "/usr/local", which made adding "/share/" necessary in all those places. But maybe I'm wrong and it should just return "/usr/local/share"?

@arrowd
Copy link
Contributor Author

arrowd commented Jan 8, 2026

Ping.

@ximion
Copy link
Owner

ximion commented Jan 10, 2026

Oh, maybe I misunderstood what PackageIndex::dataPrefix() is supposed to return. I made it return a prefix value "/usr/local", which made adding "/share/" necessary in all those places. But maybe I'm wrong and it should just return "/usr/local/share"?

That was the original intent, but that actually would have caused a bunch of consistency issues, therefore I changed that assumption (and the surrounding documentation). But it looks like the changes weren't made everywhere, which is why your patch makes sense.

Sorry for the long delay, but I didn't have a single quiet minute over the past weeks to think through this. The changes are good to go :-)

@ximion ximion merged commit 38e8384 into ximion:master Jan 10, 2026
6 checks passed
@arrowd arrowd deleted the fbsd-build-fixes branch January 11, 2026 07:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants