Fixed Issue when USE_WEIGHTS_FILE Flag Enabled#263
Fixed Issue when USE_WEIGHTS_FILE Flag Enabled#263
USE_WEIGHTS_FILE Flag Enabled#263Conversation
…without blob data file
…h blob data file weights_blob.bin
|
About the first three patches, building should be handled by the build system, but hardcoded shell sccripts. About the last one, I'm not sure what it's meant to fix. You cannot just just copy that code to a different file since it's actually auto-generated. As for the readability patch, I see there's a missing "b" for writing on Windows, but beyond that it's mostly just re-indenting the code, which is pointless. |
|
@jmvalin |
|
The weights in rnnoise_data.c are all inside a |
|
Yes but the source code is too heavy. |
Summary
Fixed some issues when
USE_WEIGHTS_FILEFlag is enabled.Description
USE_WEIGHTS_FILEFlag is enabled,rnnoise_data.cwhich has huge huge lines is not used for compile program. Butinit_rnnoiseFunction is included inrnnoise_data.cso compile must be needed.init_rnnoiseFunction intodenoise.c.weight_blob.binwithwrite_weights.c, it generated.binfile withwmode, but we are generating justbfile so I editedwaswbof file function parameter.write_weights.chas same work as old one, but I improved code readability and debugability..shscripts are compile helper for debuggers.