(closes #31) adds a base sampler protocol, reorganizes samplers and main#40
Open
qdbp wants to merge 1 commit intoxjdr-alt:mainfrom
Open
(closes #31) adds a base sampler protocol, reorganizes samplers and main#40qdbp wants to merge 1 commit intoxjdr-alt:mainfrom
qdbp wants to merge 1 commit intoxjdr-alt:mainfrom
Conversation
qdbp
force-pushed
the
gh-31-formalize-sampler-interface
branch
from
b1e1b51 to
401d428
Compare
qdbp
force-pushed
the
gh-31-formalize-sampler-interface
branch
from
401d428 to
c601285
Compare
Open
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
(closes #31)
This implements a (functional, so functions work!) protocol to define the
EntropySamplerinterface. New sampler implementations should be able to plug right into it.Specifically, we follow the jax idiom of passing state and, in addition to the obvious inputs, have the protocol be generic over two special arguments:
cfgrepresenting immutable configuration (hyperparameters) to the samplerstaterepresenting an encapsulation of the sampler state. This will be useful in more complex samplers (the baseline is currently stateless, so justNoneis used)This also refactors main slightly, promoting the
generatenested function to a generator class.This should pave the way (though does not do so yet) for the main loop to be able to easily swap out conforming sampler implementations in a type safe way.
(also this fixes up some random mismatched type annotations -- we could probably do with a fully type checker bug bash at some point)