(closes #43) Remove pytorch source from project direct reference torch#44
Closed
SinatrasC wants to merge 1 commit intoxjdr-alt:mainfrom
Closed
(closes #43) Remove pytorch source from project direct reference torch#44SinatrasC wants to merge 1 commit intoxjdr-alt:mainfrom
SinatrasC wants to merge 1 commit intoxjdr-alt:mainfrom
Conversation
Remove pytorch source from project keeping the extra settings for OS and Version.
Owner
|
@Arrabonae |
|
#48 seems the better approach. |
Author
|
It has no practical difference as metioned in my issue thread we are using c124 lets us directly reference torch and returns same packages, it is not a improvement
|
citizenhicks
suggested changes
Oct 8, 2024
Contributor
citizenhicks
left a comment
citizenhicks
left a comment
There was a problem hiding this comment.
i think #48 is a better approach to this due to the explicit reference between torch installation options
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove pytorch source from project keeping the extra settings for OS and Version. Fixes issue #43