Conversation
waruqi
commented
Feb 12, 2026
- Before adding new features and new modules, please go to issues to submit the relevant feature description first.
- Write good commit messages and use the same coding conventions as the rest of the project.
- Please commit code to dev branch and we will merge into master branch in feature
- Ensure your edited codes with four spaces instead of TAB.
- 增加新特性和新模块之前,请先到issues提交相关特性说明,经过讨论评估确认后,再进行相应的代码提交,避免做无用工作。
- 编写友好可读的提交信息,并使用与工程代码相同的代码规范,代码请用4个空格字符代替tab缩进。
- 请提交代码到dev分支,如果通过,我们会在特定时间合并到master分支上。
- 为了规范化提交日志的格式,commit消息,不要用中文,请用英文描述。
Summary of ChangesHello @waruqi, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request enhances the Xmake build system by introducing a new policy, Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Changelog
Activity
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request introduces a new policy build.release.strip to control whether symbols are stripped by default in release builds. The policy is enabled by default and has been integrated into the mode.release and mode.releasedbg rules. This is a good addition for providing more control over the build process.
I've also noticed that the mode.minsizerel rule, which is also a release mode, does not respect this new policy. For consistency, it would be great if you could also apply this policy to mode.minsizerel in this PR or a follow-up.
| -- Strip symbols by default in release mode (mode.release) | ||
| ["build.release.strip"] = {description = "Strip symbols by default in release mode.", default = true, type = "boolean"}, |
There was a problem hiding this comment.
The comment and description for the new policy mention mode.release, but this policy is also used for mode.releasedbg. To better reflect its wider scope and improve clarity, consider making the text more general. This would also account for other release modes like minsizerel if the policy is applied there in the future.
-- Strip symbols by default in release modes
["build.release.strip"] = {description = "Strip symbols by default in release modes.", default = true, type = "boolean"},